[Webkit-unassigned] [Bug 184340] Add a field to analysis_test_group table to indicate whether the its results has been sent to author.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=184340

--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 337299
  --> https://bugs.webkit.org/attachment.cgi?id=337299
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337299&action=review

I really don't think we should be making these database schema changes without a corresponding frontend or a backend change.

> Websites/perf.webkit.org/public/v3/models/test-group.js:191
> +    async updateNotifiedAuthorFlag(notified)

Why do we need this function in frontend?
Also, this should really be called didNotifyAuthor() and shouldn't take a boolean
because it never makes sense to unset the flag.

> Websites/perf.webkit.org/server-tests/privileged-api-update-test-group-tests.js:131
> +        webkit = Repository.all().filter((repository) => repository.name() == 'WebKit')[0];

Why aren't we using const webkit here instead?

> Websites/perf.webkit.org/server-tests/privileged-api-update-test-group-tests.js:135
> +        insertedGroupId = result['testGroupId'];

Ditto about doing const testGroupId here instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180413/1afd015e/attachment.html>