[Webkit-unassigned] [Bug 184498] [GStreamer] Use of playbin3 when USE_PLAYBIN3 environment variable is set

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=184498

--- Comment #3 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 337699
  --> https://bugs.webkit.org/attachment.cgi?id=337699
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337699&action=review

>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2402
>> +void MediaPlayerPrivateGStreamer::createGSTPlayBin(const gchar *playbin_name)
> 
> Please use camelCase :P

Ah also, we use char instead of gchar usually, and the star is mispositioned. Not sure why check-webkit-style didn't complain there...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180411/2f548dbb/attachment-0002.html>