[Webkit-unassigned] [Bug 184481] Non-ASCII characters are not correctly handled in data channel.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 10 20:01:59 PDT 2018


--- Comment #11 from jianjun.zhu at intel.com ---
Comment on attachment 337665
  --> https://bugs.webkit.org/attachment.cgi?id=337665

View in context: https://bugs.webkit.org/attachment.cgi?id=337665&action=review

>> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.cpp:51
>> +    return m_channel->Send({ rtc::CopyOnWriteBuffer(utf8Text.data(), utf8Text.length()), false });
> Utf8Text is not really needed, can we remove it?

We need to access text.utf8() twice if utf8Text is removed. I'm afraid converting character encoding one more time may cause extra overhead.

>> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.cpp:100
>>          // FIXME: Ensure this is correct by adding some tests with non-ASCII characters.
> We should remove the fixme

I'll remove it after test cases were added for non-ASCII characters.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180411/f6243111/attachment-0002.html>

More information about the webkit-unassigned mailing list