[Webkit-unassigned] [Bug 184481] Non-ASCII characters are not correctly handled in data channel.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 10 19:07:22 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=184481

--- Comment #5 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 337665
  --> https://bugs.webkit.org/attachment.cgi?id=337665
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337665&action=review

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.cpp:51
> +    return m_channel->Send({ rtc::CopyOnWriteBuffer(utf8Text.data(), utf8Text.length()), false });

Utf8Text is not really needed, can we remove it?

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.cpp:100
>          // FIXME: Ensure this is correct by adding some tests with non-ASCII characters.

We should remove the fixme

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180411/091e00ff/attachment-0002.html>


More information about the webkit-unassigned mailing list