[Webkit-unassigned] [Bug 184379] [WPE] Decide how to handle libWPEWebInspectorResources.so

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=184379

--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to Adrian Perez from comment #1)
> Yup, pkglibdir is probably a good option. If it's going to be installed
> alongside “WPEWebProcess” and friends, I would also make it possible to
> override the path where it is searched for using “WEBKIT_EXEC_PATH”.

No, this is a library, not an executable. I suggested moving the executables into pkglibexecdir, not pkglibdir. (On Debian, pkglibexecdir uses non-multiarch /usr/lib. And Fedora has separate /usr/libexecdir.)

> The inspector only ever needs reading resources when it's in use. While
> not in use, it does not matter that the library is not loaded. This saves
> around 2,5 MiB of RAM, and in very constrained environments it is possible
> to skip shipping it — the inspector just won't work. I could argue that
> WebKitGTK+ should follow suit and also ship a separate resources file.

Seems like really small beans to me, but OK.

> What I don't understand is why using a shared object instead of a
> “.gresource” file, and loading it with “g_resource_load()” followed
> by a call to “g_resources_register()” — which uses “mmap()” under the
> hood.

It's an implementation detail, we can change it later.

> > One way or another, we need to ensure it is API-versioned, so if we do not
> > move it to pkglibdir, we should append the API version to the library name.
> 
> Agreed. I would move it into pkglibdir.

Yeah, let's move it to pkglibdir. It will be happy there.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180411/3f7738f9/attachment-0002.html>