[Webkit-unassigned] [Bug 175569] Add the PerformanceServerTiming Interface which makes Server-Timing header timing values available to JavaScript running in the browser.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 10 13:58:39 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=175569

youenn fablet <youennf at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #337624|review?                     |review+
              Flags|                            |

--- Comment #51 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 337624
  --> https://bugs.webkit.org/attachment.cgi?id=337624
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337624&action=review

> Source/WebCore/loader/ResourceTiming.h:30
> +#include "PerformanceServerTiming.h"

Can you try forward-declare PerformanceServerTiming?

> Source/WebCore/loader/ResourceTiming.h:62
> +    ResourceTiming(const URL& url, const String& initiator, const LoadTiming& loadTiming, const NetworkLoadMetrics& networkLoadMetrics, bool allowTimingDetails, Vector<ServerTiming>&& serverTiming)

If you can forward declare PerformanceServerTiming, could you also check whether we can easily change this constructor to take r-values for each meaningful field (provided it is used only/mainly for  ResourceTiming::isolatedCopy).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180410/773d05bc/attachment-0002.html>


More information about the webkit-unassigned mailing list