[Webkit-unassigned] [Bug 184418] ImageFrame type used by non-Cocoa image decoder should not be the same as that used by ImageSource

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 10 09:46:45 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=184418

Said Abou-Hallawa <sabouhallawa at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #337504|review?                     |review+
              Flags|                            |

--- Comment #18 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
Comment on attachment 337504
  --> https://bugs.webkit.org/attachment.cgi?id=337504
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337504&action=review

> Source/WebCore/platform/image-decoders/ScalableImageDecoderFrame.cpp:2
> + * Copyright (C) 2016 Apple Inc.  All rights reserved.

2018

> Source/WebCore/platform/image-decoders/ScalableImageDecoderFrame.cpp:-113
>  #if !USE(CG)
> -bool ImageFrame::initialize(const ImageBackingStore& backingStore)

Why we still have this #ifdef? This code will not compile for CG. right?

> Source/WebCore/platform/image-decoders/gif/GIFImageDecoder.cpp:389
> +        ScalableImageDecoderFrame::DisposalMethod prevMethod = prevBuffer->disposalMethod();

I think this can also be auto.

> Source/WebCore/platform/image-decoders/png/PNGImageDecoder.cpp:759
> +    ScalableImageDecoderFrame::DisposalMethod prevMethod = prevBuffer->disposalMethod();

I thing this can also be auto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180410/85c70c9c/attachment-0002.html>


More information about the webkit-unassigned mailing list