[Webkit-unassigned] [Bug 183888] Add a bisect button to automatically schedule bisecting A/B tasks.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=183888

--- Comment #15 from dewei_zhu at apple.com ---
Comment on attachment 337249
  --> https://bugs.webkit.org/attachment.cgi?id=337249
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337249&action=review

>> Websites/perf.webkit.org/public/v3/analysis-strategies.js:143
>> +            sortingRepositories.push(repository);
> 
> So we'd put a repository to sortingRepositories only if it had ordering? That seems backwards.
> If anything, we want them if latestCommitTime wasn't set & order is present.

If a commit of one repository had a latestCommitTime, we will hit the early return in line 128.

>> Websites/perf.webkit.org/public/v3/analysis-strategies.js:185
>> +    static async _findAndSortCommitSetsWithSameRepositorySetAsCommitSetInTargetTestGroup(commitSetsInTestGroup, commitSetsToBeFiltered)
> 
> I think it's simpler to make this function take a single commit set, and a list of commits to filter from
> since we don't currently support filtering based on combined set of repositories.
> We can restructure the code as needs come up in the future.
> 
> In general, I find that the over generalization in code is usually a bad idea because we can't predict
> what the future code & feature would look like until we implement them.

Line 216-218 rely on knowing the start and end commits.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180409/172ea93b/attachment-0002.html>