[Webkit-unassigned] [Bug 184368] Added two helper functions in CommitSet which will be shared between multiple independent incoming changes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=184368

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #337392|review?                     |review-
              Flags|                            |

--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 337392
  --> https://bugs.webkit.org/attachment.cgi?id=337392
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337392&action=review

> Websites/perf.webkit.org/ChangeLog:4
> +        Added two helper functions in CommitSet which will be shared between multiple independent incoming changes.
> +        https://bugs.webkit.org/show_bug.cgi?id=184368

Don't add random helper functions like this.
Just add a function to do either.
Each WebKit bug should fix a very specific problem.
r- because of this.

> Websites/perf.webkit.org/public/v3/models/commit-set.js:91
> +    withoutRootPatchOrOwnedCommit()

Again, the semantics of this function should be reversed, and this should be called containsRootPatchOrOwnedCommit()
r- because of this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180406/3e6beb2a/attachment-0002.html>