[Webkit-unassigned] [Bug 175569] Add the PerformanceServerTiming Interface which makes Server-Timing header timing values available to JavaScript running in the browser.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 6 12:44:16 PDT 2018


youenn fablet <youennf at gmail.com> changed:

           What    |Removed                     |Added
 Attachment #337383|review?                     |review+
              Flags|                            |

--- Comment #35 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 337383
  --> https://bugs.webkit.org/attachment.cgi?id=337383

I was going to say r+, patch is not applying though.
Some comments below.

View in context: https://bugs.webkit.org/attachment.cgi?id=337383&action=review

> Source/WebCore/loader/ServerTimingParser.cpp:41
> +    if (!headerValue.isNull()) {

We should early return here.

> Source/WebCore/loader/ServerTimingParser.cpp:59
> +                    value = tokenizer.consumeTokenOrQuotedString();

If value is null here, is it fine skipping it/adding the entry or should we raise some kind of error?

> Source/WebCore/loader/ServerTimingParser.h:36
> +Vector<ServerTiming> parseServerTiming(const String&);

It would probably be good to add some unit tests for this method.
See Tools/TestWebKitAPI/Tests/ for examples.

> Source/WebCore/page/mac/WheelEventDeltaFilterMac.h:31
> +#include <wtf/MonotonicTime.h>

Probably not needed/unrelated?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180406/a4a0adf0/attachment-0002.html>

More information about the webkit-unassigned mailing list