[Webkit-unassigned] [Bug 184318] Process Swap on Navigation causes many webpages to hang

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 5 14:16:52 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=184318

Brady Eidson <beidson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #337231|                            |review-
              Flags|                            |

--- Comment #3 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 337231
  --> https://bugs.webkit.org/attachment.cgi?id=337231
Work in Progress Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337231&action=review

I had fixed this locally, not knowing someone else was working on it.

My patch was simpler:

> Source/WebKit/UIProcess/WebPageProxy.cpp:2354
>          if (action == PolicyAction::Use && navigation) {
> -            auto proposedProcess = process().processPool().processForNavigation(*this, *navigation, action);
> +            auto proposedProcess = process().processPool().processForNavigation(*this, *navigation, action, frame.isMainFrame());

Instead of adding the new parameter, I just changed 2353 to:
-        if (action == PolicyAction::Use && navigation) {
+        if (action == PolicyAction::Use && navigation && frame.isMainFrame()) {

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180405/61e6e2eb/attachment-0002.html>


More information about the webkit-unassigned mailing list