[Webkit-unassigned] [Bug 183060] [Curl][WinCairo] WinCairo should use a Public Suffix List to prevent cookies from being set for TLDs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=183060

--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 337202
  --> https://bugs.webkit.org/attachment.cgi?id=337202
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337202&action=review

> Source/WebCore/platform/URL.cpp:440
> +        return { };

std::nullopt

> Source/WebCore/platform/URL.cpp:441
> +    return std::optional<StringView> {StringView(encodedHostName.data(), encodedHostName.size())};

encodedHostName goes out of scope with this.  Why not just return an optional<UCharBuffer>?
Also, if we know it's ASCII, why don't we just make it an LCharBuffer?
Also, appendEncodedHostname should return a std::optional<something> instead of a bool and returning by reference.

> Source/WebCore/platform/curl/PublicSuffixCurl.cpp:39
> +#include "PSLDafsa.cpp"

Let's not.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180404/49f82fcc/attachment-0002.html>