[Webkit-unassigned] [Bug 184039] webkitpy: Implement coredumpctl support on linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=184039

--- Comment #16 from Daniel Bates <dbates at webkit.org> ---
(In reply to Thibault Saunier from comment #14)
> Comment on attachment 336776 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=336776&action=review
> 
> I did not change the line length and kept following PEP8, if you really
> think we should not follow the 79 line length, I could change.
> 
> >> Tools/Scripts/webkitpy/port/linux_get_crash_log.py:70
> >> +                                                   return_stderr=True)
> > 
> > Please write this on one line.
> 
> I am following pep8 as advised here:
> https://webkit.org/code-style-guidelines/#python
> 
> pep8 is pretty clear about line length:
> https://www.python.org/dev/peps/pep-0008/#maximum-line-length

It is an unwritten rule (for now - we should change this) that we do not honor PEP8's maximum line length rule. It is archaic and hurts readability. These sentiments are echoed in the thread that includes <https://lists.webkit.org/pipermail/webkit-dev/2010-April/012486.html> and is consistent with the question raised in bug 179387, comment 2.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180404/da007378/attachment-0002.html>