[Webkit-unassigned] [Bug 184224] [CMake] gperf path should be given when WebCore/css/makevalues.pl is executed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=184224

--- Comment #3 from Yousuke Kimoto <Yousuke.Kimoto at sony.com> ---
Thank you for your review.

(In reply to Konstantin Tokarev from comment #2)
> Comment on attachment 336968 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=336968&action=review
> 
> > Source/WebCore/css/makevalues.pl:34
> > +my $customGperf;
> 
> You can reduce complexity here
> 
> my $gperf = $ENV{GPERF} ? $ENV{GPERF} : "gperf";
> 
> > Source/WebCore/css/makevalues.pl:37
> > +           'gperf-executable=s' => \$customGperf);
> 
> 'gperf-executable=s' => \$gperf

I'll follow your comment.

> > Source/WebCore/css/makevalues.pl:177
> > +my $gperf = $ENV{GPERF} ? $ENV{GPERF} : ($customGperf ? $customGperf : "gperf");
> 
> ... and remove this line

Also, I'll do it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180403/5a5557de/attachment-0002.html>