[Webkit-unassigned] [Bug 184224] [CMake] gperf path should be given when WebCore/css/makevalues.pl is executed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 2 11:07:21 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=184224

--- Comment #2 from Konstantin Tokarev <annulen at yandex.ru> ---
Comment on attachment 336968
  --> https://bugs.webkit.org/attachment.cgi?id=336968
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336968&action=review

> Source/WebCore/css/makevalues.pl:34
> +my $customGperf;

You can reduce complexity here

my $gperf = $ENV{GPERF} ? $ENV{GPERF} : "gperf";

> Source/WebCore/css/makevalues.pl:37
> +           'gperf-executable=s' => \$customGperf);

'gperf-executable=s' => \$gperf

> Source/WebCore/css/makevalues.pl:177
> +my $gperf = $ENV{GPERF} ? $ENV{GPERF} : ($customGperf ? $customGperf : "gperf");

... and remove this line

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180402/a8f3bd92/attachment-0002.html>


More information about the webkit-unassigned mailing list