[Webkit-unassigned] [Bug 183346] [GTK] NetworkProcess from WebKitGtk+ 2.19.9x SIGSEVs in NetworkStorageSession (secret search callback)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=183346

--- Comment #25 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to Carlos Garcia Campos from comment #24)
> It's not the same, in the case of WlUniquePtr<wl_display> there are two api
> calls to release a wl_display depending on whether it's a client or server
> connection. Here, GUniquePtr<GList> always frees *only* the container. We
> could add a way to also release the contents, but I don't know if it's easy
> to add since GUniquePtr is a template alias of std::unique_ptr nowadays.

Ideally it would use g_list_free_full and allow specifying the GDestroyNotify as a template parameter. I *think* it should be possible.

Similarly, ideally WlUniquePtr would make it easy to specify the deleter func for wl_display. (Alternatively: just delete the instantiation for wl_display and force developers to use std::unique_ptr directly.)

That's a matter for a future patch, though, not this one.

BTW, there is also MallocPtr, which uses bmalloc instead, but it's probably not needed here since allocations should be minimal.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180402/9aa4a09f/attachment-0002.html>