[Webkit-unassigned] [Bug 184233] [Enchant] Clean up TextCheckerEnchant

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 2 08:02:31 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=184233

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at igalia.com
 Attachment #336979|review?                     |review+
              Flags|                            |

--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 336979
  --> https://bugs.webkit.org/attachment.cgi?id=336979
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336979&action=review

Nice

> Source/WebCore/platform/text/enchant/TextCheckerEnchant.cpp:43
> +    if (!dictionary)
> +        return;

Remember C++ guarantees this func is only called if the parameter is nonnull, so remove this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180402/2dd77339/attachment-0002.html>


More information about the webkit-unassigned mailing list