[Webkit-unassigned] [Bug 183888] Add a bisect button to automatically schedule bisecting A/B tasks.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=183888

--- Comment #8 from Ryosuke Niwa <rniwa at webkit.org> ---
(In reply to dewei_zhu from comment #7)
> Comment on attachment 336889 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=336889&action=review
> 
> >>>> Websites/perf.webkit.org/public/v3/models/commit-set.js:186
> >>>> +                nameParts.push(`${repository.name()}: Patch-${firstPatch.id()} - Patch-${secondPatch.id()}`);
> >>> 
> >>> I don't think it makes sense to expose the attachment ID like this. We don't do elsewhere in the UI.
> >>> If we're concerned about the length of the name, then we can just diff the name with the maximum length of name to show.
> >>> e.g. if we had WebKit-WebComponents-A.patch and WebKit-WebComponents-B.patch, we can just show:
> >>> WebKit: "...A.patch" - "...B.patch"
> >> 
> >> What if two different patch have the same name?
> > 
> > We should probably add the file size, uploaded date, etc... This seems like an unlikely scenario though. It would be confusing for humans anyway.
> 
> How about we use id as a fallback when we got two identical names?

I don't think we should ever use a file ID as a fallback. That's just a random number we generate as far as the user is concerned. Alternatively, we can automatically add (1), (2), etc... as we do for test groups but is this really a common issue? If it is, we should consider letting people modify the file name instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180402/e8619bb5/attachment-0002.html>