[Webkit-unassigned] [Bug 177690] Web Inspector: Layers tab sidebar's DOM highlight should be by row hover, not row selection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=177690

--- Comment #3 from Ross Kirsling <ross.kirsling at sony.com> ---
I(In reply to Devin Rousso from comment #2)
> Comment on attachment 322252 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=322252&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/LayerDetailsSidebarPanel.js:134
> > +        if (!node || node === this._hoveredDataGridNode)
> 
> As a precaution against having a highlight that stays visible even after the
> user has moved their mouse, I would recommend you also have a call to
> `WI.domTreeManager.hideDOMNodeHighlight();` inside an early-return for `if
> (!node)`.
> 
> > Source/WebInspectorUI/UserInterface/Views/LayerDetailsSidebarPanel.js:148
> > +        if (!this._hoveredDataGridNode)
> 
> Ditto (134).

Is this a conceivable scenario? FWIW, the logic here is ripped straight from https://trac.webkit.org/browser/webkit/trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGrid.js.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170930/4975f9fc/attachment.html>