[Webkit-unassigned] [Bug 177225] Update syncing script to be able to build binary for commit set with owned commits.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=177225

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #322162|review?                     |review+
              Flags|                            |

--- Comment #8 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 322162
  --> https://bugs.webkit.org/attachment.cgi?id=322162
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322162&action=review

> Websites/perf.webkit.org/public/v3/models/commit-set.js:72
> +    topLevelRepositories() { return Repository.sortByNamePreferringOnesWithURL(this._repositories.filter((repository) => { return !this.ownerRevisionForRepository(repository); })); }

This is pretty long.
Could you split into multiple lines.
Also, you don't need { return ~ }. You can just do this._repositories.filter((repository) => !this.ownerRevisionForRepository(repository))

> Websites/perf.webkit.org/public/v3/models/commit-set.js:220
> +    topLevelRepositories() { return Repository.sortByNamePreferringOnesWithURL(this.repositories().filter((repository) => { return !this.ownerRevisionForRepository(repository); })); }

Ditto.

> Websites/perf.webkit.org/tools/js/buildbot-syncer.js:285
> +                    const requiresBuild = value.repositoriesToCheck.map(commitSet.requiresBuildForRepository.bind(commitSet)).some((requiresBuild) => requiresBuild);

Just do repositoriesToCheck.some((commitSet) => commitSet.requiresBuildForRepository()) instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170929/d58556a8/attachment.html>