[Webkit-unassigned] [Bug 177582] Request for PDF URL targets for specific pages, sections, etc.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=177582

--- Comment #5 from Wenson Hsieh <wenson_hsieh at apple.com> ---
(In reply to Tim Horton from comment #2)
> Comment on attachment 322043 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=322043&action=review
> 
> > Source/WebKit/ChangeLog:5
> > +        <rdar://problem/33496301>
> 
> This should be 5692679; the one you mentioned is a dupe.
> 
> > Source/WebKit/WebProcess/Plugins/PDF/PDFLayerControllerSPI.h:71
> > + at property (nonatomic, strong) NSString* URLFragment;
> 
> The asterisk is on the wrong side; we put them on the left for C++ types and
> on the right for ObjC types (it's weird, I know).
> 
> > Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:1039
> > +        m_pdfLayerController.get().URLFragment = pdfURL.substring(index);
> 
> This should get wrapped in an __MAC_OS_X_VERSION_MIN_REQUIRED ifdef, because
> it's not available in shipping versions of macOS.

If I understand correctly, this should be a MIN_REQUIRED check in the implementation file and a MAX_ALLOWED check in PDFLayerControllerSPI.h?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170928/58d86f34/attachment.html>