[Webkit-unassigned] [Bug 177582] Request for PDF URL targets for specific pages, sections, etc.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=177582

--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 322043
  --> https://bugs.webkit.org/attachment.cgi?id=322043
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322043&action=review

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:1037
> +    size_t index = pdfURL.reverseFind('#');

I bet our URL parser has a better way to do this! We should ask Alex.

>> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:1039
>> +        m_pdfLayerController.get().URLFragment = pdfURL.substring(index);
> 
> This should get wrapped in an __MAC_OS_X_VERSION_MIN_REQUIRED ifdef, because it's not available in shipping versions of macOS.

Also I generally prefer the [m_pdfLayerController setURLFragment:] variant instead of dot notation in the case where you've got a RetainPtr. (.get() is so ugly)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170928/f0da138c/attachment.html>