[Webkit-unassigned] [Bug 175265] [GTK][WPE] webkit_cookie_manager_delete_all_cookies doesn't delete the cookies if called before a web process is running

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=175265

--- Comment #28 from Brady Eidson <beidson at apple.com> ---
(In reply to Carlos Garcia Campos from comment #27)
> (In reply to Brady Eidson from comment #26)
> > (In reply to Carlos Garcia Campos from comment #24)
> > > WebProcessPool has always a data store, at
> > > construction time it creates a legacy one or gets the default one 
> > 
> > I agree that is what exists in the tree today.
> > 
> > What I am saying is that this is a mistake and we need to move away from it.
> 
> Ok, what should we do instead?

It's already wrong in that web views created from one process pool already can have difference data stores from one another. Additionally, we'll soon be entering a world where one web view might use more than one data store.

So, WebProcessPool should not have a data store member. 

Everything it does that uses the data store member should instead take a data store argument.

With those principles in place, recompiling and fixing up call sites, etc etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170927/7f6da462/attachment.html>