[Webkit-unassigned] [Bug 177449] REGRESSION(r222392): [GTK] Many forms tests are failing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=177449

--- Comment #17 from Chris Dumez <cdumez at apple.com> ---
(In reply to Michael Catanzaro from comment #16)
> No hurry. Thanks.
> 
> (In reply to Chris Dumez from comment #11)
> > I will propose a fix making the code more robust against having
> > PlatformEvent::timestamp() returning 0. However, if this is really the
> > problem, I think the GTK port should make sure to to initialize it with
> > WallTime::now() when it is 0.
> 
> I did a bit of digging. It looks like this already occurs for
> PlatformKeyboardEvent and PlatformWheelEvent in the constructors for those
> events (in PlatformKeyboardEventGtk.cpp and PlatformWheelEventGtk.cpp). So
> not sure what has gone wrong there.
> 
> PlatformMouseEvent's GTK constructor takes the time instead from the
> underlying GdkEventMotion using WallTime::fromRawSeconds, which looks wrong
> because it's passing *milliseconds* into that function. But it looks like
> these broken tests involved keyboard events, not mouse events.

I believe the issue could be in WebEventFactory::createWebKeyboardEvent(). The GTK version does:
WallTime::fromRawSeconds(gdk_event_get_time(event))

I guess gdk_event_get_time(event) may return 0, which for GTK means current time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170926/cd4dae7b/attachment.html>