[Webkit-unassigned] [Bug 176089] [GTK][WPE] Fix playback of GIFs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 26 03:23:01 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=176089

--- Comment #13 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
(In reply to Zan Dobersek from comment #11)
> The m_reader deletion in GIFImageDecoder::clearFrameBufferCache() was
> introduced in bug #159089:
> http://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/image-
> decoders/gif/GIFImageDecoder.cpp#L174
> 
> If commented out, stuttering playback of GIFs is fixed. There's also no
> flickering reintroduced that was described and fixed in bug #159089, but I'd
> need someone else to double-check that.

I tested this and I can confirm it fixes the slow playback on the first loop.
This is what I tested:

$ cd /tmp
$ mkdir giftests
$ wget http://i.imgur.com/qvKlqC8.gif -O kangaroos.gif
$ wget https://people.igalia.com/clopez/wkbug/image_animations_big/bigbuck5s.gif
$ wget https://people.igalia.com/clopez/wkbug/image_animations_big/bigbuck20s.gif
$ ls -sh1
total 187M
88M bigbuck20s.gif
18M bigbuck5s.gif
82M kangaroos.gif


Then load GTK MiniBrowser with url file:///tmp/giftests and start measuring time and memory once clicked on the gif

Currently:

kangaroos:  7350 MB WebProcess memory usage --  41sec to load from disk -- 25 sec first loop --- 15 sec second lop
bigbuck5s:   515 MB WebProcess memory usage --  2.5sec to load from disk -- 7 sec first loop --- 5 sec second lop
bigbuck20s: 8500 MB WebProcess memory usage --  48sec to load from disk -- 54 sec first loop --- 20 sec second lop


After commenting this out:

kangaroos:  similar memory usage, same time to load from disk, *but* it plays fine on the first loop (15 seconds) and without glitch
bigbuck5s:  similar memory usage, same time to load from disk, *but* it plays fine on the first loop (5 seconds) and without glitch
bigbuck20s: similar memory usage, same time to load from disk, *but* it plays fine on the first loop (20 seconds) and without glitch



So I think we have at least 3 bugs:

 - 1) Slow playback of GIFs on first loop (that seems to be fixed by your suggested fix of commenting out the deletion of the m_reader)
 - 2) Slow decoding of the GIFs (even when loading from disk)
 - 3) Huge memory usage of long GIFs.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170926/9e1a210f/attachment.html>


More information about the webkit-unassigned mailing list