[Webkit-unassigned] [Bug 177477] Web Inspector: Fix Layers tab sidebar popover.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 25 17:53:19 PDT 2017
https://bugs.webkit.org/show_bug.cgi?id=177477
Ross Kirsling <ross.kirsling at sony.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #321782| |commit-queue?
Flags| |
--- Comment #2 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 321782
--> https://bugs.webkit.org/attachment.cgi?id=321782
Patch
This turns out to be mostly code removal and a bit of refactoring.
Specifically:
- Remove focus/blur/click handlers from DataGrid. This is unlike anywhere else in Web Inspector, isn't desired, and causes issue #2.
- Use willDismissPopover to dispose of popover after it has been dismissed (fixes issue #1).
- Make popover setup less convoluted.
Note that this patch also removes the DOM highlighting triggered by the data grid. I will add this back in a later patch -- it needs to be added to the data grid row itself, and to avoid polluting the legacy sidebar, I will create a new LayerDataGridRow for the purpose.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170926/664db755/attachment.html>
More information about the webkit-unassigned
mailing list