[Webkit-unassigned] [Bug 174394] Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174394

--- Comment #64 from Frederik Riedel <riedel at apple.com> ---
Comment on attachment 321709
  --> https://bugs.webkit.org/attachment.cgi?id=321709
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=321709&action=review

>> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2816
>> +        autofillElements->autofill(username, password);
> 
> Oh wait, you're missing the check to null opt. It's possible that computeAutofillElements don't find an element, right?

Done.

>>> Source/WebKitLegacy/mac/DOM/DOMHTMLInputElement.mm:704
>>> +        autofillElements->autofill(credentialsSuggestion.username, credentialsSuggestion.password);
>> 
>> use auto here as in auto autofillElements.
>> You should check for nullopt. Otherwise, the program will crash.
> 
> A clean way to write this would be:
> 
>     if (auto elements = WebCore::AutofillElements::computeAutofillElements(*IMPL))
>         elements->autofill(credentialsSuggestion.username, credentialsSuggestion.password);

Done.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170925/adb1e991/attachment.html>