[Webkit-unassigned] [Bug 174394] Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174394

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #321709|commit-queue+               |commit-queue-
              Flags|                            |

--- Comment #61 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 321709
  --> https://bugs.webkit.org/attachment.cgi?id=321709
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=321709&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2816
> +        auto autofillElements = AutofillElements::computeAutofillElements(downcast<HTMLInputElement>(*m_assistedNode));
> +        autofillElements->autofill(username, password);

Oh wait, you're missing the check to null opt. It's possible that computeAutofillElements don't find an element, right?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170925/1925eaaa/attachment.html>