[Webkit-unassigned] [Bug 177424] New: WebKit fails to build with ENABLE_NETWORK_CACHE=0

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=177424

            Bug ID: 177424
           Summary: WebKit fails to build with ENABLE_NETWORK_CACHE=0
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit2
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: Yoshiaki.Jitsukawa at sony.com
                CC: achristensen at apple.com

https://trac.webkit.org/changeset/221942/webkit introduced NetworkCache::Key and other things in NetworkCache namespace
into WebKit/NetworkProcess/cache/CacheStorageEngineCache, but NetworkCache::* is not defined unless ENABLE(NETWORK_CACHE) is true
and this causes WebKit to fail to build.

The definition in WebKit/config.h is 
#ifndef ENABLE_NETWORK_CACHE
#if PLATFORM(COCOA) || USE(SOUP)
#define ENABLE_NETWORK_CACHE 1
#else
#define ENABLE_NETWORK_CACHE 0
#endif
#endif

and it seems like all webkit(2) port enable it today.

Should we support the case ENABLE_NETWORK_CACHE==0 or should all webkit(2) port (including upcoming windows one) enable network cache?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170925/df18a6f2/attachment.html>