[Webkit-unassigned] [Bug 177293] [Win64] Crashes in Yarr JIT compiled code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=177293

--- Comment #4 from Fujii Hironori <Hironori.Fujii at sony.com> ---
(In reply to Yusuke Suzuki from comment #3)
> Looks good to me.
> Could you upload the patch with ChangeLog and test?

Thank you for your feedback.
I don't think a new test is needed because existing LayoutTests (ex. js/string_replace_regexp.html) can reproduce the crash.
I will create a patch.

> > Source/JavaScriptCore/yarr/YarrJIT.cpp:2855
> > +        push(X86Registers::ecx);
> 
> It would be good to add comment here that it is the pointer to the result in
> x64 Windows.

Agreed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170922/4135c8aa/attachment.html>