[Webkit-unassigned] [Bug 177115] Web Inspector: Add details sidebar to Layers tab.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=177115

Matt Baker <mattbaker at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #321389|1                           |0
        is obsolete|                            |

--- Comment #10 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 321389
  --> https://bugs.webkit.org/attachment.cgi?id=321389
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321389&action=review

Mostly style/nits.

> Source/WebInspectorUI/UserInterface/Views/LayerDetailsSidebarPanel.css:49
> +    color: hsl(0, 0%, 50%);

color: var(--text-color-gray-medium);

> Source/WebInspectorUI/UserInterface/Views/LayerDetailsSidebarPanel.css:53
> +    color: hsla(0, 0%, 100%, 0.75);

color: var(--selected-secondary-text-color);

> Source/WebInspectorUI/UserInterface/Views/LayerDetailsSidebarPanel.css:68
> +

Remove extra newline.

> Source/WebInspectorUI/UserInterface/Views/LayerDetailsSidebarPanel.css:70
> +

Remove extra newline.

> Source/WebInspectorUI/UserInterface/Views/LayerDetailsSidebarPanel.css:76
> +    flex: 1;

display and flex properties are typically at the top.

> Source/WebInspectorUI/UserInterface/Views/LayerDetailsSidebarPanel.css:107
> +    --layer-popover-ul-padding-start: 1em;

-webkit-margin-start: 1em;
-webkit-padding-start: 1em;

Then you can remove the direction-specific rules that follow.

> Source/WebInspectorUI/UserInterface/Views/LayerDetailsSidebarPanel.js:52
> +        let layers = objects.filter((object) => object instanceof WI.Layer);

Parentheses can be omitted: (object) -> object.

> Source/WebInspectorUI/UserInterface/Views/LayerDetailsSidebarPanel.js:113
> +        {

Helper functions defined within methods should have opening parenthesis on same line as function header.

> Source/WebInspectorUI/UserInterface/Views/LayerDetailsSidebarPanel.js:115
> +            let item2 = b.layer[sortColumnIdentifier] || 0;

Style: we typically write `itemA` `itemB` in comparators.

> Source/WebInspectorUI/UserInterface/Views/LayerDetailsSidebarPanel.js:266
> +        let dimensionsTitle = content.appendChild(document.createElement("p"));

Prefer <div> over <p>. Nothing here is semantically a paragraph.

> Source/WebInspectorUI/UserInterface/Views/LayerDetailsSidebarPanel.js:283
> +        let reasonsTitle = content.appendChild(document.createElement("p"));

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170921/93413a91/attachment-0001.html>