[Webkit-unassigned] [Bug 176620] In regular block layout, the width of a child's margin box should always be equal to that of its containing block

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=176620

--- Comment #15 from Zhifei Fang <facetothefate at gmail.com> ---
(In reply to zalan from comment #13)
> Comment on attachment 321174 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=321174&action=review
> 
> >>> LayoutTests/fast/block/over-constrained-auto-margin.html:21
> >>> +        <script>
> >> 
> >> I think this test could just dump the render tree, and not run any script.
> > 
> > I am not sure about "dump the render tree", do we dump it as a picture? if so, the margin right will not been show in the picture, the error happened with the computed style it is should be -116px instead of -106px, we cannot tell it on the picture.
> 
> Dumping the render tree means something like this ->
> layer at (0,0) size 943x600
>   RenderView at (0,0) size 800x600
> layer at (0,0) size 800x528
>   RenderBlock {HTML} at (0,0) size 800x528
>     RenderBody {BODY} at (8,8) size 784x0
>       RenderBlock {DIV} at (0,0) size 935x0
>         RenderBlock (floating) {DIV} at (0,0) size 935x500 [bgcolor=#EEEEEE]
>           RenderBlock {DIV} at (0,0) size 935x500 [bgcolor=#ADD8E6]
>         RenderBlock (floating) {DIV} at (0,0) size 146x300 [bgcolor=#A9A9A9]
>         RenderBlock (floating) {DIV} at (635,0) size 300x300
> [bgcolor=#A9A9A9]
> 
> But I think running script is fine, it's just I don't see why you remove the
> child at the end. Shouldn't it be something like instead?
> document.body.offsetHeight; 
> shouldBe("getComputedStyle(target1).marginRight", "'-116px'");
> shouldBe("getComputedStyle(target2).marginLeft", "'-116px'");
> (no need to do getElementById)

Got it, thanks !

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170920/8e5e7d4a/attachment-0001.html>