[Webkit-unassigned] [Bug 177115] Web Inspector: Add details sidebar to Layers tab.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 20 11:56:39 PDT 2017


--- Comment #5 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 321172
  --> https://bugs.webkit.org/attachment.cgi?id=321172

View in context: https://bugs.webkit.org/attachment.cgi?id=321172&action=review

>> Source/WebInspectorUI/UserInterface/Views/LayerDetailsSidebarPanel.js:269
>> +        compositedRow.appendChild(document.createElement("td")).textContent = layer.compositedBounds.width + "px à " + layer.compositedBounds.height + "px";
> I suppose this should be rewritten to use `WI.UIString("%d \xd7 %d pixels")` instead of a raw string.

We use raw unicode characters in CSS and JS (such as dashes). I think that's okay here, although the multiplication sign is visually similar to an "x".

Utilities.js defines some commonly used characters at the top:

var emDash = "\u2014";
var enDash = "\u2013";
var figureDash = "\u2012";
var ellipsis = "\u2026";
var zeroWidthSpace = "\u200b";

You could add:
var multiplicatationSign = "\u00d7";

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170920/4f9cc91e/attachment-0001.html>

More information about the webkit-unassigned mailing list