[Webkit-unassigned] [Bug 174394] Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 20 11:28:21 PDT 2017


--- Comment #42 from Frederik Riedel <riedel at apple.com> ---
Comment on attachment 321328
  --> https://bugs.webkit.org/attachment.cgi?id=321328

View in context: https://bugs.webkit.org/attachment.cgi?id=321328&action=review

>> Source/WebKitLegacy/mac/DOM/DOMHTMLInputElement.h:39
>> +#elif
> elif what? This is causing the build failure.

Yes, this should be #else.

>> Source/WebKitLegacy/mac/DOM/DOMHTMLInputElement.mm:46
>> +#endif
> You need to wrap this whole thing in #if PLATFORM(IOS) or #if TARGET_OS_IPHONE

Right. Even if the UIKit include is not available we would try to #import it in #else. This breaks the build on Mac. 
I wrapped the whole thing in an additional check for #if TARGET_OS_IPHONE.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170920/6967a2f7/attachment.html>

More information about the webkit-unassigned mailing list