[Webkit-unassigned] [Bug 177134] WebDriver: Implement commands to get and set the window rect

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=177134

Brian Burg <bburg at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #321196|review?                     |review+
              Flags|                            |

--- Comment #3 from Brian Burg <bburg at apple.com> ---
Comment on attachment 321196
  --> https://bugs.webkit.org/attachment.cgi?id=321196
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321196&action=review

r=me

> Source/WebDriver/ChangeLog:13
> +        (WebDriver::Session::getToplevelBrowsingContextRect): Helper to get the window rext. This is used by both get

Nit: 'rect'

> Source/WebDriver/Session.cpp:678
> +void Session::moveToplevelBrowsingContextwindow(double x, double y, Function<void (CommandResult&&)>&& completionHandler)

Nit: 'moveToplevelBrowsingContextWindow'

> Source/WebDriver/Session.cpp:695
> +void Session::resizeToplevelBrowsingContextwindow(double width, double height, Function<void (CommandResult&&)>&& completionHandler)

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170919/89f90e9a/attachment.html>