[Webkit-unassigned] [Bug 176970] Should not mark a platform as missing in summary page if all expecting metrics are exlucded.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=176970

--- Comment #4 from dewei_zhu at apple.com ---
Comment on attachment 320853
  --> https://bugs.webkit.org/attachment.cgi?id=320853
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320853&action=review

>>> Websites/perf.webkit.org/public/v3/pages/summary-page.js:281
>>> +            if (!foundInSomeMetric && excludedMerticCount < metrics.length)
>> 
>> Now we don't need foundInSomeMetric. You can just check excludedMerticCount < metrics.length
>> since that condition also implies metrics.length.
> 
> I don't think we can do this.
> excludedConfigurations[platform.id()] just specifies the expected missing combinations for a platform. So it could be a subset of metrics. In this case, removing foundInSomeMetric could result in marking a platform missing incorrectly.

For 'excludedConfigurations[platform.id()] just specifies the expected missing combinations for a platform' I meant 'excludedConfigurations[platform.id()] just specifies the expected missing Metrics for a platform.'

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170915/424d6829/attachment.html>