[Webkit-unassigned] [Bug 176970] Should not mark a platform as missing in summary page if all expecting metrics are exlucded.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=176970

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #320853|review?                     |review+
              Flags|                            |

--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 320853
  --> https://bugs.webkit.org/attachment.cgi?id=320853
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320853&action=review

> Websites/perf.webkit.org/public/v3/pages/summary-page.js:265
>              var foundInSomeMetric = false;
> +            var excludedMerticCount = 0;

Use let.

> Websites/perf.webkit.org/public/v3/pages/summary-page.js:281
> -            if (!foundInSomeMetric)
> +            if (!foundInSomeMetric && excludedMerticCount < metrics.length)

Now we don't need foundInSomeMetric. You can just check excludedMerticCount < metrics.length
since that condition also implies metrics.length.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170915/6b9205a6/attachment.html>