[Webkit-unassigned] [Bug 175265] [GTK][WPE] webkit_cookie_manager_delete_all_cookies doesn't delete the cookies if called before a web process is running
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 13 11:27:06 PDT 2017
https://bugs.webkit.org/show_bug.cgi?id=175265
Brady Eidson <beidson at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #319250|review? |review-
Flags| |
--- Comment #22 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 319250
--> https://bugs.webkit.org/attachment.cgi?id=319250
Updated patch
View in context: https://bugs.webkit.org/attachment.cgi?id=319250&action=review
Note that this patch is obsoleted by https://trac.webkit.org/changeset/221834/webkit, and will need to be rethought.
> Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h:68
> + WebsiteDataStore* defaultWebsiteDataStore() const { return m_defaultWebsiteDataStore.get(); }
> + void setDefaultWebsiteDataStore(WebsiteDataStore& websiteDataStore) { m_defaultWebsiteDataStore = &websiteDataStore; }
This name is problematic:
"default website data store" is already an established concept in the APIWebsiteDataStore API.
But also, please note that we need to move *away* from the concept of a process pool having a default datastore and this patch further cements the concept.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170913/4643fbdc/attachment.html>
More information about the webkit-unassigned
mailing list