[Webkit-unassigned] [Bug 176686] Remove duplicated test results from LayoutTest platform directories

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=176686

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at igalia.com
 Attachment #320551|review?                     |review+
              Flags|                            |

--- Comment #17 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 320551
  --> https://bugs.webkit.org/attachment.cgi?id=320551
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320551&action=review

r=me if it passes all the EWS bots

> Tools/Scripts/check-for-duplicated-platform-test-results:29
> +layout_tests_directory = os.path.join(checkout_root, "LayoutTests")
> +platform_directory = os.path.join(layout_tests_directory, "platform")

Nit: please don't switch between using single quotes and double quotes for strings in the same script. I would stick with single quotes, since that's what most of our WebKit scripts use, and using single quotes also matches the GNOME style to use double quotes only for translatable strings.

> Tools/Scripts/check-for-duplicated-platform-test-results:110
> +    print "%d found in %s -> generic" % (duplicates_len, " -> ".join([os.path.basename(p) for p in baseline_search_path[:-1]]))

And here you've switched back to double quotes, though you used single quotes for most of the script.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170912/3ebf8ddb/attachment.html>