[Webkit-unassigned] [Bug 176761] The WebKit build system is forcing a non UTF-8 locale and breaks meson.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=176761

--- Comment #3 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
(In reply to Carlos Alberto Lopez Perez from comment #2)
> (In reply to Michael Catanzaro from comment #1)
> > So, we definitely need to use a UTF-8 locale always. That should go without
> > saying. Our platform is not non-UTF-8 safe anymore and I expect there is no
> > shortage of odd bugs caused by using a weird locale.
> > 
> > Anyway, apparently commit-queue can't handle UTF-8. Or couldn't in the past,
> > see bug #71983. So we'll need to test to see if commit queue breaks when we
> > change this.
> > 
> 
> 
> I think this is not longer an issue.
> 
> 1) I have checked and all the GTK/WPE bots are right now producing text with
> UTF8 strings. This is because disable_gcc_smartquotes() is not called on the
> normal build done by the buildbots, only for the EWS bots.
> 
> Example:
> https://build.webkit.org/builders/GTK%20Linux%20ARM%20Release/builds/1051/
> steps/compile-webkit/logs/stdio/text
> 
> 
> 2) Both the build.webkit.org as the EWS log server are now setting proper
> mime-type:
> 
> * EWS:
> $ curl -i https://webkit-queues.webkit.org/results/4489980 2>&1 |grep
> ^Content-Type:
> Content-Type: text/plain; charset=utf-8
> 
> * build.webkit.org
> $ curl -i
> https://build.webkit.org/builders/GTK%20Linux%20ARM%20Release/builds/1051/
> steps/compile-webkit/logs/stdio/text 2>&1 |grep ^Content-
> Content-Type: text/plain; charset=utf-8
> 
> 
> And any browser that is not able to understand text/plain with charset=utf-8
> (or confuses that with binary data) in 2017 has bigger problems that go
> beyond this issue.
> 
> So the issue raised in
> https://lists.webkit.org/pipermail/webkit-dev/2014-January/026140.html (not
> sure if was the same) should not be an issue anymore. 
> 

I think the issue raised on the mailing list was related to the VT100 characters that JHBuild generates that are not UTF8. For that we are setting TERM=none with environment.disable_jhbuild_VT100_output(). We can keep that as this one makes sense. I also set on the bots the TERM variable to disable the terminal control codes from JHBuild


So, taken everything into account I think is safe now to remove the environment.disable_gcc_smartquotes() thing

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170912/a9a08c56/attachment.html>