[Webkit-unassigned] [Bug 176680] webkitbot should recognize commands even when colon is omitted

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 11 11:55:31 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=176680

--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org> ---
(In reply to Daniel Bates from comment #3)
> Comment on attachment 320414 [details]
> Fixe the bug
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=320414&action=review
> 
> > Tools/Scripts/webkitpy/common/net/irc/ircbot.py:92
> >              request = request.split(':', 1)
> >          elif vocative_separator == ',':
> >              request = request.split(',', 1)
> > +        elif vocative_separator == ' ':
> > +            request = request.split(' ', 1)
> 
> We could simplify this code by using an array and the "in" operator

That's a good point, let's do that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170911/3dd126f1/attachment.html>


More information about the webkit-unassigned mailing list