[Webkit-unassigned] [Bug 176680] webkitbot should recognize commands even when colon is omitted
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 11 09:20:11 PDT 2017
https://bugs.webkit.org/show_bug.cgi?id=176680
Daniel Bates <dbates at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dbates at webkit.org
Attachment #320414|review?, commit-queue? |review+, commit-queue+
Flags| |
--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 320414
--> https://bugs.webkit.org/attachment.cgi?id=320414
Fixe the bug
View in context: https://bugs.webkit.org/attachment.cgi?id=320414&action=review
> Tools/Scripts/webkitpy/common/net/irc/ircbot.py:92
> request = request.split(':', 1)
> elif vocative_separator == ',':
> request = request.split(',', 1)
> + elif vocative_separator == ' ':
> + request = request.split(' ', 1)
We could simplify this code by using an array and the "in" operator
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170911/d90896d4/attachment.html>
More information about the webkit-unassigned
mailing list