[Webkit-unassigned] [Bug 176508] WebDriver: ensure we close all windows handles when closing the session

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=176508

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Brian Burg from comment #3)
> Comment on attachment 320110 [details]
> Patch
> 
> r=me

Thanks!

> Couldn't this still race with JS that closes or navigations a window somehow?

Yes, I think it's quite unlikely that something happens after the quit command (the problem in this case was a window closed before the quit command), and we are getting the window list again after closing every window. But yes, it could still happen. I think we could simply ignore NoSuchWindow errors when closing the session, if we try to close a window and the window no longer exists, there's no reason to fail.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170909/5a38fffd/attachment.html>