[Webkit-unassigned] [Bug 174394] Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174394

--- Comment #30 from Frederik Riedel <riedel at apple.com> ---
Comment on attachment 319277
  --> https://bugs.webkit.org/attachment.cgi?id=319277
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319277&action=review

>> Source/WebCore/editing/Editor.h:281
>> +#endif
> 
> Hm... now that I'm looking at this, it might be better to have a class named AutofillElements and make these functions members of that class.

Done.

>> Source/WebCore/editing/ios/EditorIOS.mm:490
>> +static inline RefPtr<Element> nextAutofillableElement(Node* startNode, Page& page, bool isForward)
> 
> I think it's better to have two functions one called nextAutofillableElement and previousAutofillableElement instead of taking isForward argument given how small the actual code is.

Done.

>> Source/WebCore/editing/ios/EditorIOS.mm:495
>> +    Element* nextElement = downcast<Element>(startNode);
> 
> Use RefPtr instead.

Done.

>> Source/WebCore/editing/ios/EditorIOS.mm:539
>> +                autofillElements.password = &inputElement;
> 
> We don't have username in this case?

Yes. This is the case where a standalone password field should be filled.

>> Source/WebCore/editing/ios/EditorIOS.mm:544
>> +    return autofillElements;
> 
> We should return nullopt here instead.

OK, done.

>> Source/WebCore/editing/ios/EditorIOS.mm:551
>> +}
> 
> This function is not needed once computeAutofillElements returns nullopt in the case neither username nor password is set.
> The caller of this function can just check !Editor::computeAutofillElements(start) then.

Makes sense, removed.

>> Source/WebCore/html/HTMLInputElement.cpp:900
>> +
> 
> We're not using this function. Please remove.

Removed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170907/28865cfe/attachment-0001.html>