[Webkit-unassigned] [Bug 176497] New: [GTK] Bring back line height rounding when computing font metrics

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=176497

            Bug ID: 176497
           Summary: [GTK] Bring back line height rounding when computing
                    font metrics
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Keywords: Gtk
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: cgarcia at igalia.com
                CC: bugs-noreply at webkitgtk.org

In r221670 we changed the way we get the metrics to avoid rounding that was causing a negative line gap to be computed. Since the font metrics value is indeed a float value, we also removed the rounding when setting the line height. However, this caused some test failures because now we report non integer line heights, see for example:

https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r221719%20(3018)/fast/css/font-calculated-value-pretty-diff.html
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r221719%20(3018)/fast/ruby/ruby-line-height-pretty-diff.html

I think it would be better to bring back the rounding for consistency with all other ports, but also with other browsers. This will require another rebaseline, but a lot smaller :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170907/e8ec2303/attachment.html>