[Webkit-unassigned] [Bug 176442] [Win] Tools/TestWebKitAPI/Tests/WTF/PriorityQueue.cpp fails to compile with MSVC 2015

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 5 23:36:04 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=176442

--- Comment #5 from Keith Miller <keith_miller at apple.com> ---
(In reply to Yoshiaki Jitsukawa from comment #4)
> (In reply to Keith Miller from comment #2)
> > Comment on attachment 319986 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=319986&action=review
> > 
> > Looks pretty good to me. Minor nit though.
> > 
> > > Tools/TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:59
> > > +#if defined(_MSC_VER) && _MSC_VER < 1910 // FIXME: Remove this after we stop supporting MSVC 2015.
> > 
> > Can you file a bugzilla for this and link to it in your FIXMEs?
> 
> Thank you for your suggestion. I've filed Bug 176443.

Great, thanks! Can you update your patch to link to your bug too?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170906/e91c2a89/attachment-0001.html>


More information about the webkit-unassigned mailing list