[Webkit-unassigned] [Bug 176069] [WinCairo] Add Network Process files for wincairo webkit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 1 10:44:45 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=176069

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #319612|                            |review-
              Flags|                            |

--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 319612
  --> https://bugs.webkit.org/attachment.cgi?id=319612
Add basic versions/stubs for Network Process files for wincairo webkit (no LegacyCustomProtocolManager)

View in context: https://bugs.webkit.org/attachment.cgi?id=319612&action=review

> Source/WebKit/NetworkProcess/win/SystemProxyWin.cpp:70
> +        goto exitGracefully;
> +
> +    wcstombs(buffer, tHost, bufferLen);
> +    result = true;
> +
> +exitGracefully:
> +    if (tRegBuffer)
> +        delete [] tRegBuffer;

This is what std::unique_ptr<TCHAR[]> is for.  Let's not add goto for this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170901/8429c6a6/attachment.html>


More information about the webkit-unassigned mailing list