[Webkit-unassigned] [Bug 177993] Add UI for A/B testing on owned commits.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=177993

--- Comment #4 from dewei_zhu at apple.com ---
Comment on attachment 323075
  --> https://bugs.webkit.org/attachment.cgi?id=323075
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323075&action=review

>> Websites/perf.webkit.org/ChangeLog:70
>> +        (CommitLog.prototype.label): Remove the logic that adds 'r' prefix to svn revision since some revisions from a repository sometimes are labeled with 'r' sometimes are not.
> 
> Why? That sounds like a bug somewhere. revision() should never return a value with 'r' prefix.

Revisions from same repository could be like '123' and '123.1'. For 123, label will add 'r' as prefix. However, for '123.1', it will not be prefixed with 'r'.
Another way is we specify certain type of characters are allowed to occur in a revision (e.g. (. , -)).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171101/6339f372/attachment.html>