[Webkit-unassigned] [Bug 179047] OwnedCommitViewer should include the preceding commit.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179047

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #325426|review?                     |review+
              Flags|                            |

--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 325426
  --> https://bugs.webkit.org/attachment.cgi?id=325426
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325426&action=review

> Websites/perf.webkit.org/public/v3/components/commit-log-viewer.js:39
> +        let fetchSingleCommit = !precedingRevision || precedingRevision == lastRevision;

Use const.

> Websites/perf.webkit.org/public/v3/components/commit-log-viewer.js:59
> +                this._precedingCommit = precedingCommit[0];

You should check this._fetchingPromise != promise here to avoid showing results for the old range.

> Websites/perf.webkit.org/public/v3/components/commit-log-viewer.js:88
> +        let commits_to_process = commits && precedingCommit && precedingCommit.ownsCommits() ? [precedingCommit].concat(commits) : commits;

Use camelCase. In fact, I think we can just assign directly to commits in the case we have precedingCommit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171031/72f4295a/attachment.html>