[Webkit-unassigned] [Bug 142673] [GTK] Automatically adjust font size when gtk-xft-dpi changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 30 14:39:10 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=142673

--- Comment #16 from Gabriel Ivașcu <givascu at igalia.com> ---
(In reply to Michael Catanzaro from comment #14)
> You'll need to move the declaration down into the #if PLATFORM(GTK) block
> you added below to avoid this warning for WPE. It's C++ so the code style
> for declarations is different: you should limit the scope of variables by
> declaring them only where they're actually required, rather than at the top
> of functions.
> 
> I forgot to tell you that there are separate WebKitSettings.h files for GTK
> and WPE, and they have to be updated in tandem. I know that's yucky, but the
> only alternative is to generate the headers from a common template, and we
> haven't gone down that road yet. So you'll have to take care of that too.

OK, I fixed this and the coding style in attachment 325377

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171030/41d1395c/attachment-0001.html>


More information about the webkit-unassigned mailing list